Skip to content

Bump Ruff to 0.11.4 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 10, 2025
Merged

Bump Ruff to 0.11.4 #30

merged 9 commits into from
Apr 10, 2025

Conversation

YifuTao
Copy link
Collaborator

@YifuTao YifuTao commented Apr 10, 2025 •
edited
Loading

  • replace chartboost/ruff-action (discontinued) with astral-sh/ruff-action
    • The old version only ran the ruff check, not ruff format. The Github action missed some formatting problem therefore.
    • I did not use the default astral-sh/ruff-action@v3 which just runs ruff check. I made it more explicit to run three stages. See d8e337c
  • bump ruff from 0.8.1 to 0.11.4
    • in 0.9.0 there is a format change. See this blog post.
  • load ruff config from pyroject.toml in both pre-commit and Github action. This ensures that all ruff we run are consistent. In particular, we set the max line width to 120 in pyproject.
  • add pre-commit and ruff as the dependencies for the pip installation

@YifuTao YifuTao merged commit 650bcfc into main Apr 10, 2025
2 checks passed
@YifuTao YifuTao deleted the et-ruff branch April 10, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YifuTao